Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix macOS workflow and update on-push branches #602

Merged
merged 1 commit into from
May 7, 2024

Conversation

azeey
Copy link
Contributor

@azeey azeey commented May 3, 2024

🦟 Bug fix

Summary

This applies some the changes from https://github.com/gazebosim/sdformat/blob/1c0bc304d43285223e69e52abc8c3d9269d67713/.github/workflows/macos.yml to fix broken Github Action on macOS (see #587).

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@azeey azeey requested a review from marcoag as a code owner May 3, 2024 19:57
@github-actions github-actions bot added 🌱 garden Ignition Garden 🎵 harmonic Gazebo Harmonic labels May 3, 2024
@mjcarroll mjcarroll merged commit 27ee4d6 into gz-common5 May 7, 2024
12 of 13 checks passed
@mjcarroll mjcarroll deleted the azeey/fix_macos branch May 7, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden 🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants